Readpref #10
Closed
Readpref #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craiggwilson
force-pushed
the
readpref
branch
from
3923ceb to
955e950
Compare
jyemin
requested changes
Feb 13, 2017
core/readpref/selector.go
Outdated
|
|
||
| switch cluster.Type { | ||
| case desc.Single: | ||
| return servers, nil |
There was a problem hiding this comment.
Can servers contain any of type Unknown? If so it needs to be filtered out here.
core/readpref/selector.go
Outdated
| return selectByType(servers, desc.Mongos), nil | ||
| } | ||
|
|
||
| return nil, nil |
There was a problem hiding this comment.
Return an error for unsupported cluster type
core/readpref/selector.go
Outdated
| return nil | ||
| } | ||
|
|
||
| fmt.Printf("HERE") |
core/readpref/readpref.go
Outdated
| // New constructs a read preference from the mode and optionally | ||
| // some name value pairs. | ||
| func New(mode Mode, tagSets ...desc.TagSet) *ReadPref { | ||
| // TODO: think about having an error for invalid construction |
There was a problem hiding this comment.
Reminding me of Namespace. Let's just make sure we're consistent where it makes sense, both for error checking and for private/public fields.
craiggwilson
force-pushed
the
readpref
branch
2 times, most recently
from
db37f9a to
74153f4
Compare
craiggwilson
force-pushed
the
readpref
branch
from
74153f4 to
3ad6b97
Compare
|
removing and will put up a new one when it's ready. |
prestonvasquez
added a commit
that referenced
this pull request
Mar 22, 2022
* GODRIVER-2277 Remove causal consistency prose test #10 * GODRIVER-2277 Remove causal consistency prose test no. 10 * add unack writes subtest to TestSessions * couple assertion and msg * use non-verbose error handling * allow error reassignment * make assert msg more verbose * clean up assert msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added readpref package and tests.