GODRIVER-2311 Improve the BSON unmarshal buffer reuse fix to reduce memory allocations. #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emory allocations.
kevinAlbs
approved these changes
Mar 31, 2022
matthewdale
added a commit
that referenced
this pull request
Mar 31, 2022
…emory allocations. (#891)
kevinAlbs
pushed a commit
to kevinAlbs/mongo-go-driver
that referenced
this pull request
Mar 31, 2022
…emory allocations. (mongodb#891)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2311
As of the fix in #874, we no longer return values that point to the same underlying byte array as the input from
bson.Unmarshal. However, the fix copies byte slices that are returned to the caller and byte slices that are copied to byte arrays or converted to other values by the caller. Improve the previous fix to reduce the unnecessary additional copy while maintaining the correct behavior.