GODRIVER-2311 Ensure unmarshaled BSON values always use distinct unde… #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlying byte arrays. (mongodb#874)
benjirewis
reviewed
Mar 29, 2022
bson/bsonrw/value_reader.go
Outdated
| return vr.d[start : start+int64(length)], nil | ||
|
|
||
| b := make([]byte, length) | ||
| copy(b, vr.d[start:start+int64(length)]) |
There was a problem hiding this comment.
Depending on the result of #891, this copy may be moved to the ReadBinary function (cc @matthewdale), in which case we should probably do the same on the release/1.7 branch.
There was a problem hiding this comment.
I just opened #891 for review. Agreed we should review that before back-porting this fix.
There was a problem hiding this comment.
Thank you for the heads up. I have added the commit onto this PR.
…emory allocations. (mongodb#891)
benjirewis
approved these changes
Mar 31, 2022
|
Here is the second patch build with one task running tests in the bson package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rlying byte arrays. (#874)
Background & Motivation
Backporting to 1.7.0 is against the policy of backporting to the most recent minor release. Backporting to 1.7.0 intends to provide this fix to the majority of active Go driver users.
The other tests from d307af8 are not cherry-picked since they were made after additional changes to unmarshal_test.go and unmarshal_cases_test.go in c918d8c.
There is no Evergreen project tracking the release/1.7 branch. But here is a patch build with one task running tests in the bson package.
Summary
TestUnmarshalByteSlicesUseDistinctArraystest.