This repository was archived by the owner on Dec 23, 2021. It is now read-only.
HHVM-239: Allow users to set a limit on acceptable staleness #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ array(2) { | |||
| ["is_passive"]=> | |||
| bool(false) | |||
| ["last_is_master"]=> | |||
| array(8) { | |||
| array(9) { | |||
There was a problem hiding this comment.
Would it make more sense to just use %d here, as we typically do for object fields (even when we enumerate all of them in the expected output)?
There was a problem hiding this comment.
I did that for the PHPC one already - the problem is more that different versions of MongoDB include different items. Hence me doing: mongodb/mongo-php-driver@6462468#diff-3bb29f65077b3f49f6e05c7d78fdab99R53
Will fix that here too.
|
LGTM. |
derickr
force-pushed
the
HHVM-239-maxstaleness
branch
from
0c6036c to
98b9c56
Compare
derickr
added a commit
that referenced
this pull request
Sep 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #126 (and sorry for the random test fix for tests/MongoDBDriverManager_debugInfo.phpt)