This repository was archived by the owner on Dec 23, 2021. It is now read-only.
HHVM-161, HHVM-191: WriteResult should use libmongoc's public API #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
force-pushed
the
HHVM-161-write-result-encapsulate-bson
branch
2 times, most recently
from
90539e8 to
b6ef7bf
Compare
| obj->o_set(s_nMatched, Variant(a[s_nMatched]), s_MongoDriverWriteResult_className); | ||
| obj->o_set(s_nRemoved, Variant(a[s_nRemoved]), s_MongoDriverWriteResult_className); | ||
| obj->o_set(s_nInserted, Variant(a[s_nInserted]), s_MongoDriverWriteResult_className); | ||
| obj->o_set(s_nModified, Variant(a[s_nModified]), s_MongoDriverWriteResult_className); |
There was a problem hiding this comment.
Will this fall back to null if the "nModified" field is missing in the BSON document?
There was a problem hiding this comment.
Yes. I've just tested this by passing in s_info instead of s_nMatched (which doesn't exist), and the value turned into a NULL.
derickr
force-pushed
the
HHVM-161-write-result-encapsulate-bson
branch
from
b6ef7bf to
896ec02
Compare
|
LGTM. I realized I didn't actually encounter this in PHPC yet because I've not started PHPC-628 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.