This repository was archived by the owner on Dec 23, 2021. It is now read-only.
HHVM-193: executeBulkWrite() should throw InvalidArgumentException for empty BulkWrite #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $m = new MongoDB\Driver\Manager("mongodb://localhost:27017"); | ||
| cleanup( $m ); | ||
|
|
||
| $bw = new MongoDB\Driver\BulkWrite( [ 'ordered' => false ] ); |
There was a problem hiding this comment.
Is [ 'ordered' => false ] relevant? I'd think to just leave the ctor arg empty for conciseness.
There was a problem hiding this comment.
No, not relevant. I just copied it from somewhere else. I'll fix it.
|
LGTM pending question above. |
…r empty BulkWrite
derickr
force-pushed
the
HHVM-193-empty-bulkwrite-invalidargumentexception
branch
from
8e01db2 to
567c0af
Compare
derickr
added a commit
that referenced
this pull request
Mar 22, 2016
derickr
added a commit
that referenced
this pull request
Mar 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.