Fixed PHP-1425: explain() does not raise appropriate exception for conditions

[derickr]

No description provided.

[bjori]

It doesn't have to be both in the catch() and outside it.
Also, on failure this test won't print anything - thats abit confusing. how about ending with echo ok or ===DONE=== ? :]

[derickr]

I know it doesn't need to be in both, but it's just to be on the safe side :-)

[bjori]

Looks like travis doesn't agree with you on the error code.

Was explain() the only helper that relied on MongoCursor::next() doing the error handling? No other helpers missing php_mongo_handle_error() ?

[jmikola]

Was explain() the only helper that relied on MongoCursor::next() doing the error handling? No other helpers missing php_mongo_handle_error() ?

From a quick grep, it looks like the legacy collection/index enumeration, php_mongo_runcommand, and php_mongo_collection_findone all called php_mongo_handle_error, as did the relevant cursor functions. Of note, findAndModify uses php_mongo_runcommand, so we're covered there. I can't imagine the other command helpers do anything differently.

[bjori]

lgtm then.
the new testcase also reads better \o/