This repository was archived by the owner on Feb 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 327
Fixed PHP-1425: explain() does not raise appropriate exception for conditions #843
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
--TEST-- | ||
Test for PHP-1425: explain() does not raise appropriate exception for $err conditions | ||
--SKIPIF-- | ||
<?php require_once "tests/utils/standalone.inc"; ?> | ||
--FILE-- | ||
<?php | ||
require_once "tests/utils/server.inc"; | ||
|
||
$host = MongoShellServer::getStandaloneInfo(); | ||
$m = new MongoClient($host); | ||
|
||
$m->admin->command( array( 'setParameter' => 1, 'notablescan' => 1 ) ); | ||
|
||
$c = $m->selectCollection(dbname(), collname(__FILE__)); | ||
|
||
$c->drop(); | ||
$c->insert( array( 'foo' => 'bar' ) ); | ||
try | ||
{ | ||
$c->find( array( 'foo' => 'bar' ) )->explain(); | ||
echo "FAILED: MongoCursorException should have been thrown\n"; | ||
} | ||
catch ( MongoCursorException $e ) | ||
{ | ||
// Error message and code vary between server versions, so don't assert their values | ||
echo "MongoCursorException was thrown\n"; | ||
} | ||
|
||
?> | ||
===DONE=== | ||
--CLEAN-- | ||
<?php | ||
require_once "tests/utils/server.inc"; | ||
|
||
$host = MongoShellServer::getStandaloneInfo(); | ||
$m = new MongoClient($host); | ||
$m->admin->command(array('setParameter' => 1, 'notablescan' => 0)); | ||
|
||
?> | ||
--EXPECTF-- | ||
MongoCursorException was thrown | ||
===DONE=== |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't have to be both in the catch() and outside it.
Also, on failure this test won't print anything - thats abit confusing. how about ending with echo ok or ===DONE=== ? :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it doesn't need to be in both, but it's just to be on the safe side :-)