PHPC-1496: Add support for compiling with libmongocrypt #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
phpc-1496
branch
4 times, most recently
from
1e33b00 to
cb73b1b
Compare
kevinAlbs
reviewed
Dec 4, 2019
alcaeus
changed the title
jmikola
reviewed
Dec 10, 2019
jmikola
reviewed
Dec 11, 2019
jmikola
reviewed
Dec 11, 2019
jmikola
reviewed
Dec 16, 2019
|
Regarding the todo item "Ensure libmongocrypt is built with crypto support and reports it correctly (issue found on MacOS)", this is due to us not including mongocrypt-config.h in php_phongo.c, so Since we are using the same library as for libmongoc crypto, it may be more appropriate to rename that output from "libmongoc crypto" to something more generic that covers both libmongoc and libmongocrypt. |
jmikola
reviewed
Dec 18, 2019
jmikola
reviewed
Dec 19, 2019
jmikola
reviewed
Dec 19, 2019
jmikola
reviewed
Dec 20, 2019
|
Incoming PR: alcaeus#3 |
jmikola
approved these changes
Dec 20, 2019
|
Done. I also squashed commits for a cleaner history 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1496
Commits will be squashed before merging.
Open items: