PHPC-1185: Revert GSSAPI support and fix sasl_client_done check #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
May 18, 2018
| PHP_ADD_FRAMEWORK([GSS]) | ||
| fi | ||
| PHP_MONGODB_SASL="gssapi" | ||
| ]) |
There was a problem hiding this comment.
@kvwalker found another bug with the original implementation. Although this added the GSS framework on macOS, it didn't stop the subsequent PKG_CHECK_MODULES check for krb5-gssapi and still resulted in an error if that library wasn't found. Had we kept this, we would want to ensure that the AS_IF([test "$PHP_MONGODB_SASL" = "gssapi" -o "$PHP_MONGODB_SASL" = "auto"],[ block later on never runs.
This is a moot point since we're deleting the code, but I wanted to make a note of it for future reference.
|
Note: Changes in #841 should address Windows builds. |
libmongoc does not actually support GSSAPI (CDRIVER-2170), so we should not allow building with it. This also reverts preference for the GSS framework on macOS (PHPC-1142).
The check for sasl_client_done was inadvertently removed by aab92e1. This ensures that we check for the symbol regardless of whether SASL was found with pgk-config or PHP_CHECK_LIBRARY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1185
https://jira.mongodb.org/browse/PHPC-1142
Reverts support for building with GSS framework on macOS or krb5-gssapi, as libmongoc doesn't support those. Additionally, this fixes an issue with the check for
sasl_client_done.