PHPC-1174: Upgrade bundled libmongoc to 1.10.0 #841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAJL was removed in libbson 1.6.0 (CDRIVER-1370).
jmikola
changed the title
This was referenced May 21, 2018
derickr
approved these changes
May 22, 2018
| @@ -58,44 +58,50 @@ if (PHP_MONGODB != "no") { | |||
| ADD_EXTENSION_DEP("mongodb", "openssl", false); | |||
|
|
|||
| var PHP_MONGODB_CFLAGS="\ | |||
| /D BSON_COMPILATION /D MONGOC_COMPILATION /D MONGOC_TRACE \ | |||
| /D BSON_COMPILATION /D MONGOC_COMPILATION \ | |||
There was a problem hiding this comment.
Did libmongoc remove the tracing?
There was a problem hiding this comment.
This was moved to a mongoc-config.h constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1174
This should address the changes between our last submodule bump and 1.10. Also includes changes to
config.w32for Windows builds.