PHPC-1076: Expose result document for failed commands via CommandFailedEvent #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvwalker
reviewed
May 18, 2018
| int(9) | ||
| ["codeName"]=> | ||
| string(13) "FailedToParse" | ||
| } |
There was a problem hiding this comment.
This test fails because var_dump($event->getReply()) returns an object that includes operationTime, $clusterTime, and signature.
This can be fixed by adding
["operationTime"]=>
object(MongoDB\BSON\Timestamp)#%d (2) {
["increment"]=>
string(1) "1"
["timestamp"]=>
string(10) "%d"
}
["$clusterTime"]=>
object(stdClass)#%d (2) {
["clusterTime"]=>
object(MongoDB\BSON\Timestamp)#%d (2) {
["increment"]=>
string(1) "1"
["timestamp"]=>
string(10) "%d"
}
["signature"]=>
object(stdClass)#%d (2) {
["hash"]=>
object(MongoDB\BSON\Binary)#%d (2) {
["data"]=>
string(20) "%s"
["type"]=>
int(0)
}
["keyId"]=>
int(0)
}
There was a problem hiding this comment.
Thanks for catching that. It didn't come up with overview.php because I was already using %A there for 3.2 compatibility.
|
Note: Changes in #841 should address Windows builds. |
MongoDB 3.4 introduced a codeName field to error replies, so we use a wildcard to ignore that for 3.2 servers.
3.6 replica sets may include additional fields in the command response (e.g. operationTime, $clusterTime).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-1076
Supersedes #818. This includes the bump to libmongoc 1.10-dev and test suite changes for connection strings and skip functions.