Ship .gitattributes file to shrink the dist package
#1020
Conversation
This is considered a best practice AFAIK
OskarStark
force-pushed
the
gitattributes
branch
from
bb7d4c2 to
440ad22
Compare
| tests export-ignore | ||
| docs export-ignore | ||
| examples export-ignore | ||
| mongo-orchestration export-ignore |
There was a problem hiding this comment.
This directory hasn't been updated in over two years and I think it's obsolete since stopped using Travis CI and migrated to GitHub Actions (including the mongo-orchestration action in drivers-evergreen-tools). I also found no references to this directory in the project.
@alcaeus: Do you concur that we should remove it entirely?
There was a problem hiding this comment.
Opened PHPLIB-1058 to track this.
| examples export-ignore | ||
| mongo-orchestration export-ignore | ||
| tools export-ignore | ||
| Makefile export-ignore |
There was a problem hiding this comment.
This file might just be a candidate for removal, per #1021 (comment).
| docs export-ignore | ||
| examples export-ignore | ||
| mongo-orchestration export-ignore | ||
| tools export-ignore |
There was a problem hiding this comment.
I think it makes sense to include examples/ and tests/ in exports since they're intended for our users. @alcaeus: thoughts?
There was a problem hiding this comment.
I would prefer to refer to the documentation in this case. If someone really needs this, one can hop over to github or use prefer source composer option.
We save a lot of traffic when thinking about CI ✌🏻
It's up to you 🤓
There was a problem hiding this comment.
I'm admittedly in the minority of users that frequently jumps through the vendor/ directory to reference code. The impact on CI and users specifying --prefer-source are both good points. I'm on board with stripping all of this from the git archive in that case.
I will open PRs when back from vacation 👍 |
This is considered a best practice AFAIK