Skip to content

Place .PHONY in front of the commands #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

OskarStark
Copy link
Contributor

No description provided.

@@ -1,7 +1,6 @@
.PHONY: composer test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, there's no functional difference between enumerating all phony targets here or doing so individually. One benefit to the individual approach you're suggesting here is that the attribute is closer to the target definition and we'd be less likely to forget to update this line when adding/removing a phony target down the line. Is that correct?


I'll defer to @alcaeus to chime in here when he returns from PTO, but I actually think this entire Makefile can just be removed. The test target isn't accurate since we actually use vendor/bin/simple-phpunit (as mentioned in CONTRIBUTING.md).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no technical difference, that's right.

However I prefer to have the PHONY next to the target, it makes a cleaner diff and if you copy paste a target, it's more easy to not forget it.

If you prefer to remove the Makefile @alcaeus, I will provide a PR

@OskarStark
Copy link
Contributor Author

I was lazy and used the Update branch button in the Github UI 😄

@alcaeus
Copy link
Member

alcaeus commented Jan 10, 2023

Closing as the Makefile can definitely be removed. I'm running sanity checks on the mongo-orchestration folder (as drivers-evergreen-tools can use files from the project directory) before creating a PR to drop this as part of PHPLIB-1058.

@alcaeus alcaeus closed this Jan 10, 2023
@OskarStark OskarStark deleted the phony-makefile branch January 10, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants