Skip to content

PHPLIB-1435: Integrate static analysis for releases #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2024
Merged

PHPLIB-1435: Integrate static analysis for releases #1308

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec8596a
PHPLIB-1435: Integrate static analysis for releases
alcaeus May 7, 2024
55741d3
Extract setup action and split static analysis job
alcaeus May 21, 2024
9bb0486
Use correct capitalisation for acronym
alcaeus May 21, 2024
48a6fde
Upgrade to latest rector version
alcaeus May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
- "v*.*"
- "master"
- "feature/*"
tags:
- "*"
Copy link
Member

@GromNaN GromNaN May 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analysis will be performed twice on the same commit: 1) for the push on master, 2) for the tag. I presume it's so that the results are linked correctly to the tag.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct.


env:
PHP_VERSION: "8.2"
Expand Down Expand Up @@ -60,11 +62,10 @@ jobs:
- name: "Run Psalm"
run: "vendor/bin/psalm --show-info=false --stats --output-format=github --threads=$(nproc) --report=psalm.sarif"

- name: "Upload sarif report"
uses: "github/codeql-action/upload-sarif@v3"
with:
sarif_file: psalm.sarif

- name: "Run Rector"
run: "vendor/bin/rector --ansi --dry-run"

- name: "Upload Psalm report"
uses: actions/upload-artifact@v4
with:
name: psalm.sarif
path: psalm.sarif
Loading