PHPLIB-1435: Integrate static analysis for releases #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
May 13, 2024
| @@ -12,6 +12,8 @@ on: | |||
| - "v*.*" | |||
| - "master" | |||
| - "feature/*" | |||
| tags: | |||
| - "*" | |||
There was a problem hiding this comment.
The analysis will be performed twice on the same commit: 1) for the push on master, 2) for the tag. I presume it's so that the results are linked correctly to the tag.
jmikola
reviewed
May 13, 2024
|
You can remove rector if it blocks. |
GromNaN
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1435
This extracts a commit from #1288 to get code scanning integrated before we automate releases.