Skip to content

PHPLIB-1080: Spec tests for command events databaseName property #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2024
Merged

PHPLIB-1080: Spec tests for command events databaseName property #1309

merged 1 commit into from
May 21, 2024

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented May 20, 2024

@jmikola jmikola requested a review from a team as a code owner May 20, 2024 18:33
@jmikola jmikola requested a review from alcaeus May 20, 2024 18:33
alcaeus
alcaeus approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Static analysis failures are unrelated and will be merged once the changes from #1308 is merged up to master.

@jmikola
PHPLIB-1080: Spec tests for command events databaseName property
31bcd54 
Bumps PHPC requirement to 1.19 for PHPC-2255.
@jmikola jmikola merged commit 7e3bfff into mongodb:master May 21, 2024
27 checks passed
@jmikola jmikola deleted the phplib-1080 branch May 21, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmikola @alcaeus