PHPLIB-366: Change streams test runner #616
Conversation
|
Rebased on master after merging #615. This should still wait until mongodb/specifications#567 is merged, since it requires a test fix. |
jmikola
force-pushed
the
phplib-366
branch
2 times, most recently
from
25ea007 to
15cd18c
Compare
| /* These should all pass before the driver can be considered compatible with | ||
| * MongoDB 4.2. */ | ||
| private static $incompleteTests = [ | ||
| 'change-streams: Test consecutive resume' => 'PHPLIB-416', |
There was a problem hiding this comment.
There is actually no reason for this to fail. I believe the problem is that I'm using iterator_to_array() to capture the change stream result rather than the documented iteration procedure.
Will attempt to get this fixed and passing before we merge.
There was a problem hiding this comment.
Just to confirm, this was actually one of the two bugs cited below: PHPLIB-442
|
@kvwalker: This is ready for another look. While implementing this, I came across two bugs that appear to date back to the original implementation in 1.3.0: I'd like to PHPLIB-442 in the active release branch (i.e. 1.4.x) and then merge up to master. PHPLIB-443 can wait for 1.5.0 since it would be difficult to test this in v1.4 (we don't have anything using fail points there). Also, this may be more of a behavior change and better suited to a minor version bump where users might be more inclined to read release notes. |
Support placeholders in DocumentsMatchConstraint and allow CommandExpectations to ignore extra events. Also removes abstract from base spec test class. Spec tests synced with mongodb/specifications@a1c9d3c
Depends on #615. Can be rebased after that is merged.
https://jira.mongodb.org/browse/PHPLIB-366