PHPLIB-443: Propagate non-resumable errors during ChangeStream iteration #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Jun 17, 2019
|
|
||
| $this->expectException(ServerException::class); | ||
| $this->expectExceptionCode($errorCode); | ||
| $changeStream->rewind(); |
There was a problem hiding this comment.
Since the initial aggregate returns an empty first batch, this rewind() is sufficient to invoke the first getMore by way of phongo_cursor_advance_and_check_for_error(), which calls mongoc_cursor_next().
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-443
This PR is a single commit, but depends on #616.
The fifth prose test serves as a regression test for this bug.