Skip to content

PHPLIB-920: Command monitoring and change stream examples #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

jmikola
Copy link
Member

@jmikola jmikola commented Sep 16, 2022

@jmikola jmikola requested a review from alcaeus September 16, 2022 02:47
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding those examples!

@jmikola
Copy link
Member Author

jmikola commented Sep 16, 2022

Pushed some changes as I noticed the scripts were using invalid syntax for some older PHP versions. Opened PHPLIB-981 to catch that going forward.

Also pushed some fixes for CS and static analysis (to be later handled by PHPLIB-979).

@jmikola jmikola merged commit 153f61d into mongodb:master Sep 16, 2022
@jmikola jmikola deleted the phplib-920 branch September 16, 2022 18:35
levon80999 pushed a commit to levon80999/mongo-php-library that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants