Skip to content

CLOUDP-113839: [Mongocli] Split the packaging and release variants into two separate ones #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2022
Merged

CLOUDP-113839: [Mongocli] Split the packaging and release variants into two separate ones #1000

merged 1 commit into from
Feb 28, 2022

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Feb 25, 2022 •
edited
Loading

Proposed changes

Jira ticket: CLOUDP-113839

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

We should split the packaging and release variants into two separate ones so that we can reuse the same task.
This PR should address this comment #999 (review)

@andreaangiolillo andreaangiolillo marked this pull request as ready for review February 25, 2022 17:20
@andreaangiolillo andreaangiolillo requested a review from a team February 25, 2022 17:20
gssbzn
gssbzn approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTEVG

@andreaangiolillo andreaangiolillo merged commit 89c1fa2 into master Feb 28, 2022
@andreaangiolillo andreaangiolillo deleted the CLOUDP-113839 branch February 28, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaangiolillo @gssbzn