Skip to content

CLOUDP-120668: Add register command skeleton #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 27, 2022
Merged

CLOUDP-120668: Add register command skeleton #1149

merged 4 commits into from
Apr 27, 2022

Conversation

blva
Copy link
Collaborator

@blva blva commented Apr 26, 2022

Proposed changes

Jira ticket: CLOUDP-120668

➜  mongocli git:(CLOUDP-120668) atlasdev auth register --help
Register with MongoDB Atlas.

Usage:
  atlas auth register [flags]

Examples:
  To start the interactive setup:
  $ atlas auth register


Flags:
      --gov          Register to Atlas for Government.
  -h, --help         help for register
      --noBrowser    Don't try to open a browser session.
      --skipConfig   Skip profile configuration.

Global Flags:
  -P, --profile string   Profile to use from your configuration file.
➜  mongocli git:(CLOUDP-120668) atlasdev auth register
Create and verify your MongoDB Atlas account from the web browser and return to Atlas CLI after activation.

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

cmd := &cobra.Command{
Use: "register",
Short: "Register with MongoDB Atlas.",
Hidden: true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command is hidden, no doc generated until we flip it.

@blva blva marked this pull request as ready for review April 26, 2022 16:05
@blva blva requested a review from a team April 26, 2022 16:05
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments but in general LGTM

@blva blva requested a review from gssbzn April 26, 2022 16:40
gssbzn
gssbzn previously approved these changes Apr 26, 2022
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva requested a review from a team April 26, 2022 19:20
JuliaMongo
JuliaMongo previously approved these changes Apr 26, 2022
Copy link
Contributor

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Bianca! Left two small comments.

@blva blva dismissed stale reviews from JuliaMongo and gssbzn via 4bd8226 April 27, 2022 07:43
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blva blva merged commit f08e168 into master Apr 27, 2022
@blva blva deleted the CLOUDP-120668 branch April 27, 2022 07:55
Copy link
Contributor

@JuliaMongo JuliaMongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants