-
Notifications
You must be signed in to change notification settings - Fork 88
CLOUDP-120668: Add register command skeleton #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
// Copyright 2022 MongoDB Inc | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package auth | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/mongodb/mongocli/internal/cli/require" | ||
"github.com/mongodb/mongocli/internal/config" | ||
"github.com/spf13/cobra" | ||
) | ||
|
||
type registerOpts struct { | ||
loginOpts | ||
} | ||
|
||
func (opts *registerOpts) Run() error { | ||
_, _ = fmt.Fprintf(opts.OutWriter, "Create and verify your MongoDB Atlas account from the web browser and return to Atlas CLI after activating your account.\n") | ||
// TODO: CLOUDP-120669 | ||
return nil | ||
} | ||
|
||
func RegisterBuilder() *cobra.Command { | ||
opts := ®isterOpts{} | ||
cmd := &cobra.Command{ | ||
Use: "register", | ||
Short: "Register with MongoDB Atlas.", | ||
Hidden: true, | ||
Example: fmt.Sprintf(` To start the interactive setup: | ||
$ %s auth register | ||
`, config.BinName()), | ||
PreRunE: func(cmd *cobra.Command, args []string) error { | ||
if hasUserProgrammaticKeys() { | ||
return fmt.Errorf(`you have already set the programmatic keys for this profile. | ||
|
||
Run '%s auth register --profile <profileName>' to use your username and password with a new profile`, config.BinName()) | ||
} | ||
|
||
opts.OutWriter = cmd.OutOrStdout() | ||
opts.config = config.Default() | ||
if config.OpsManagerURL() != "" { | ||
opts.OpsManagerURL = config.OpsManagerURL() | ||
} | ||
return opts.initFlow() | ||
}, | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
return opts.Run() | ||
}, | ||
Args: require.NoArgs, | ||
} | ||
|
||
cmd.Flags().BoolVar(&opts.isGov, "gov", false, "Register to Atlas for Government.") | ||
cmd.Flags().BoolVar(&opts.noBrowser, "noBrowser", false, "Don't try to open a browser session.") | ||
cmd.Flags().BoolVar(&opts.skipConfig, "skipConfig", false, "Skip profile configuration.") | ||
|
||
return cmd | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
// Copyright 2022 MongoDB Inc | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
//go:build unit | ||
// +build unit | ||
|
||
package auth | ||
|
||
import ( | ||
"bytes" | ||
"testing" | ||
|
||
"github.com/golang/mock/gomock" | ||
"github.com/mongodb/mongocli/internal/mocks" | ||
"github.com/mongodb/mongocli/internal/test" | ||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestRegisterBuilder(t *testing.T) { | ||
test.CmdValidator( | ||
t, | ||
RegisterBuilder(), | ||
0, | ||
[]string{"gov", "noBrowser"}, | ||
) | ||
} | ||
|
||
func Test_registerOpts_Run(t *testing.T) { | ||
ctrl := gomock.NewController(t) | ||
mockFlow := mocks.NewMockAuthenticator(ctrl) | ||
mockConfig := mocks.NewMockLoginConfig(ctrl) | ||
mockStore := mocks.NewMockProjectOrgsLister(ctrl) | ||
defer ctrl.Finish() | ||
buf := new(bytes.Buffer) | ||
|
||
loginOpts := &loginOpts{ | ||
flow: mockFlow, | ||
config: mockConfig, | ||
noBrowser: true, | ||
skipConfig: true, | ||
} | ||
|
||
opts := ®isterOpts{ | ||
*loginOpts, | ||
} | ||
|
||
opts.OutWriter = buf | ||
opts.Store = mockStore | ||
|
||
require.NoError(t, opts.Run()) | ||
assert.Equal(t, `Create and verify your MongoDB Atlas account from the web browser and return to Atlas CLI after activating your account. | ||
`, buf.String()) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the command is hidden, no doc generated until we flip it.