Skip to content

test(NODE-4271): sync fle2 api spec tests #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 22, 2022
Merged

test(NODE-4271): sync fle2 api spec tests #3273

merged 19 commits into from
Jun 22, 2022

Conversation

durran
Copy link
Member

@durran durran commented May 27, 2022 •
edited
Loading

Description

Syncs the FLE2 spec tests for DRIVERS-2297

What is changing?

Syncs the FLE2 spec tests to this commit: mongodb/specifications@c3784d4

Is there new documentation needed for these changes?

No

What is the motivation for this change?

NODE-4271/DRIVERS-2297

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-4271 branch 2 times, most recently from 41adac6 to 88d3a8e Compare May 27, 2022 12:57
@durran durran marked this pull request as ready for review May 27, 2022 13:18
@durran durran force-pushed the NODE-4271 branch 2 times, most recently from 4f26120 to fc6d8a5 Compare May 27, 2022 14:31
@durran
Copy link
Member Author

durran commented May 27, 2022 •
edited
Loading

The fle failures in evergreen are fixed in #3271

addaleax
addaleax reviewed May 31, 2022
View reviewed changes
addaleax
addaleax previously approved these changes May 31, 2022
View reviewed changes
@durran durran force-pushed the NODE-4271 branch 3 times, most recently from 618781c to 31ea2a5 Compare June 10, 2022 17:59
durran
durran commented Jun 22, 2022
View reviewed changes
durran
durran commented Jun 22, 2022
View reviewed changes
durran
durran commented Jun 22, 2022
View reviewed changes
durran
durran commented Jun 22, 2022
View reviewed changes
@durran durran requested a review from nbbeeken June 22, 2022 16:29
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 22, 2022
@durran
Copy link
Member Author

durran commented Jun 22, 2022

Also note that fle2-validatorAndPartialFieldExpression.json/yml was part of this PR (mongodb/specifications#1227) but we actually already synced them in: 4121ec6

@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 22, 2022
@nbbeeken nbbeeken merged commit aa652ae into main Jun 22, 2022
@nbbeeken nbbeeken deleted the NODE-4271 branch June 22, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

@addaleax addaleax addaleax left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@durran @addaleax @nbbeeken @dariakp