-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-4251): sync csfle create spec tests #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes the failing fle2 tests in evergreen for the events count mismatch - adding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of failing tests now - which ones, exactly, are expected to fail and why?
All of them are expected to fail and be resolved in another PR or if we wait on https://jira.mongodb.org/browse/SERVER-66901 |
Is that the reason for all 11 failures? The error messages look different, some of them expect an error but are currently passing, and your original comment only mentioned expected failures for two tests. |
Actually the one error expecting an error is a legitimate bug - I'm looking into where we missed that validation. |
I skipped the related we've been seeing failures in this PR: #3281, once it's in you can rebase and unskip them here, its isolated so easy to do git wise but at least other PRs can go green on 6.0 |
mongodb/libmongocrypt#364 merges and the int/long contention errors are fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting to update the fle dependency to merge so that all tests are passing
Description
Adds list collections assertions in the create spec tests plus tests for create indexes and collmod.
What is changing?
Spec test sync. mongodb/specifications@f0d1330 and mongodb/specifications@2fd6b69
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4251/DRIVERS-2309
Double check the following
npm run check:lint
script<type>(NODE-xxxx)<!>: <description>