test(NODE-4262): simplify leak checker for startSession fixes #3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
test/leak-checker-fixes
branch
from
0aba7e2 to
f7c9172
Compare
nbbeeken
force-pushed
the
test/leak-checker-fixes
branch
from
7d0afae to
ab5683d
Compare
nbbeeken
added
the
Primary Review
Co-authored-by: Bailey Pearson <[email protected]>
baileympearson
requested changes
Jun 2, 2022
test/integration/client-side-encryption/client_side_encryption.spec.test.js
Outdated
Show resolved
Hide resolved
baileympearson
approved these changes
Jun 3, 2022
dariakp
reviewed
Jun 3, 2022
| ...(isAuthEnabled | ||
| ? skippedAuthTests.concat(skippedMaxWireVersionTest) | ||
| : [skippedMaxWireVersionTest]), | ||
| // TODO(NODE-4288): Fix FLE 2 tests |
There was a problem hiding this comment.
should we leave a comment on Durran's current fle2 spec sync PR (NODE-4251) to rebase so that we can make sure to keep things consistent?
There was a problem hiding this comment.
Linked the jira, commented on GH, will comment on JIRA in a sec. I needed to skip these to check that there wasn't something hanging the run related to these changes.
dariakp
requested changes
Jun 3, 2022
baileympearson
added
Team Review
5 tasks
dariakp
changed the title
dariakp
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Make the leak checker operate on MongoClient and ServerSessionPool.
What is the motivation for this change?
Simplifies the tracking of resources for the forthcoming change where sessions are managed on the client instead of the topology.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>