chore(NODE-4348): enhance skip reason filtering in unified runner #3303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-4348
branch
from
7cffd8d to
d098a78
Compare
baileympearson
changed the title
nbbeeken
suggested changes
Jun 28, 2022
test/integration/unified-test-format/unified_test_format.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/unified-test-format/unified_test_format.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/unified-test-format/unified_test_format.spec.test.ts
Outdated
Show resolved
Hide resolved
test/integration/unified-test-format/unified_test_format.spec.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Neal Beeken <[email protected]>
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
previously approved these changes
Jun 28, 2022
durran
requested changes
Jun 28, 2022
|
Also 1 lint issue. |
- fix lint error - update type to return false instead of null when tests should be run
nbbeeken
approved these changes
Jun 29, 2022
durran
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR enhances the skip test functionality of the unified runner. Rather than accepting an array of tests to skip, the runner now takes a function that is evaluated to determine whether a test should be skipped.
This PR also updates the existing usages of
runUnifedSuitethat skip tests to use the new function approach.Finally, some tests relating to auto connect and change stream resumability were unskipped.
Is there new documentation needed for these changes?
Negative.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>