Skip to content

chore(NODE-5822): sync CSOT spec tests and setup prose stubs #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Sync spec tests
  • Stub prose tests
Is there new documentation needed for these changes?

None

What is the motivation for this change?

Stubbing out the tests will remove a major portion of the diff as we're able to start enabling them

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 11, 2024
@aditi-khare-mongoDB
Copy link
Contributor

All failing CI tests are flaky tests or data lake (which currently always fails)

@W-A-James W-A-James self-requested a review January 11, 2024 21:59
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 11, 2024
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we file the follow-up tickets, can we add TODOs to these test files where relevant that reference the respective ticket?

@nbbeeken nbbeeken merged commit 86e2659 into main Jan 12, 2024
@nbbeeken nbbeeken deleted the NODE-5822-sync-csot-tests branch January 12, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants