-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(NODE-5822): sync CSOT spec tests and setup prose stubs #3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
508 changes: 508 additions & 0 deletions
508
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Large diffs are not rendered by default.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
test/integration/client-side-operations-timeout/client_side_operations_timeout.spec.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { join } from 'path'; | ||
|
||
import { loadSpecTests } from '../../spec'; | ||
import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner'; | ||
|
||
// TODO(NODE-5823): Implement unified runner operations and options support for CSOT | ||
describe.skip('CSOT spec tests', function () { | ||
runUnifiedSuite(loadSpecTests(join('client-side-operations-timeout'))); | ||
}); |
51 changes: 51 additions & 0 deletions
51
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/* eslint-disable @typescript-eslint/no-empty-function */ | ||
/** | ||
* The following tests are described in CSOTs spec prose tests as "unit" tests | ||
* The tests enumerated in this section could not be expressed in either spec or prose format. | ||
* Drivers SHOULD implement these if it is possible to do so using the driver's existing test infrastructure. | ||
*/ | ||
|
||
// TODO(NODE-5824): Implement CSOT prose tests | ||
describe.skip('CSOT spec unit tests', () => { | ||
context('Operations should ignore waitQueueTimeoutMS if timeoutMS is also set.', () => {}); | ||
|
||
context( | ||
'If timeoutMS is set for an operation, the remaining timeoutMS value should apply to connection checkout after a server has been selected.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'If timeoutMS is not set for an operation, waitQueueTimeoutMS should apply to connection checkout after a server has been selected.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'If a new connection is required to execute an operation, min(remaining computedServerSelectionTimeout, connectTimeoutMS) should apply to socket establishment.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'For drivers that have control over OCSP behavior, min(remaining computedServerSelectionTimeout, 5 seconds) should apply to HTTP requests against OCSP responders.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'If timeoutMS is unset, operations fail after two non-consecutive socket timeouts.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'The remaining timeoutMS value should apply to HTTP requests against KMS servers for CSFLE.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'The remaining timeoutMS value should apply to commands sent to mongocryptd as part of automatic encryption.', | ||
() => {} | ||
); | ||
|
||
context( | ||
'When doing minPoolSize maintenance, connectTimeoutMS is used as the timeout for socket establishment.', | ||
() => {} | ||
); | ||
}); |
4 changes: 4 additions & 0 deletions
4
test/integration/client-side-operations-timeout/node_csot.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/* eslint-disable @typescript-eslint/no-empty-function */ | ||
/* Anything javascript specific relating to timeouts */ | ||
|
||
describe.skip('CSOT driver tests', () => {}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.