Skip to content

refactor(NODE-6056): implement MongoDBResponse class #4062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 8, 2024
Merged

refactor(NODE-6056): implement MongoDBResponse class #4062

merged 9 commits into from
Apr 8, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 28, 2024 •
edited
Loading

Description

What is changing?

  • Fixes and closes: NODE-3946
  • Moves BSON parsing to OnDemandDocument
  • Adds a subclass that provides getters for common command response properties
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • In service of future improvements and optimizations
  • Typesafe responses

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken
nbbeeken commented Mar 29, 2024
View reviewed changes
@nbbeeken nbbeeken force-pushed the NODE-6056-response branch from 59e5f64 to 5e860c1 Compare March 29, 2024 14:56
nbbeeken
nbbeeken commented Mar 29, 2024
View reviewed changes
Copy link
Contributor Author

@nbbeeken nbbeeken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://spruce.mongodb.com/version/66085dc31549960007d3a292

@nbbeeken nbbeeken force-pushed the NODE-6056-response branch 2 times, most recently from aecc0eb to 824f17c Compare March 30, 2024 18:45
Base automatically changed from NODE-6055-on-demand to main April 2, 2024 22:23
@nbbeeken nbbeeken force-pushed the NODE-6056-response branch 4 times, most recently from 147a9ef to c35643f Compare April 3, 2024 17:31
@nbbeeken nbbeeken marked this pull request as ready for review April 3, 2024 19:17
@baileympearson baileympearson self-assigned this Apr 4, 2024
baileympearson
baileympearson requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing major, looks good overall

nbbeeken
nbbeeken commented Apr 4, 2024
View reviewed changes
@nbbeeken nbbeeken requested a review from baileympearson April 4, 2024 20:31
@nbbeeken nbbeeken force-pushed the NODE-6056-response branch from c7032c0 to d5621c9 Compare April 4, 2024 21:54
@nbbeeken nbbeeken mentioned this pull request Apr 5, 2024
Merged
5 tasks
@nbbeeken nbbeeken force-pushed the NODE-6056-response branch from 8fd52e6 to 199d77b Compare April 5, 2024 16:39
@baileympearson baileympearson added the Team Review Needs review from team label Apr 5, 2024
@W-A-James W-A-James self-requested a review April 5, 2024 19:01
W-A-James
W-A-James approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Looking at the perf tests, we're also doing well with these changes. 🚀

@baileympearson baileympearson merged commit 30cac05 into main Apr 8, 2024
@baileympearson baileympearson deleted the NODE-6056-response branch April 8, 2024 16:19
baileympearson added a commit to baileympearson/node-mongodb-native that referenced this pull request Apr 15, 2024
@nbbeeken @baileympearson
refactor(NODE-6056): implement MongoDBResponse class (mongodb#4062)
a66d1d6 
Co-authored-by: Bailey Pearson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@W-A-James W-A-James W-A-James approved these changes

Assignees

@baileympearson baileympearson

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbbeeken @baileympearson @W-A-James