test(NODE-3903): update connections survive stepdown tests to check CMAP events #4071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
chore-fix-cmap-tests
branch
from
e7f2c48 to
3483bc2
Compare
nbbeeken
force-pushed
the
chore-fix-cmap-tests
branch
from
3483bc2 to
1509bf9
Compare
durran
added
the
Primary Review
durran
reviewed
Apr 15, 2024
|
|
||
| beforeEach( | ||
| skipBrokenAuthTestBeforeEachHook({ | ||
| skippedTests: [ |
There was a problem hiding this comment.
Nice we don't have to skip these any more.
durran
approved these changes
Apr 15, 2024
durran
added
Team Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
These tests started failing in #4062 debugging them proved difficult and they need to be updated anyway.
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript