Skip to content

Deprecate CGLIB proxy factory #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Conversation

harawata
Copy link
Member

@harawata harawata commented Mar 30, 2022

It's unmaintained and does not work with JDK 17.
https://github.com/cglib/cglib
Users should use Javassist instead.

It's unmaintained and does not work with JDK 17.
Users should use Javassist instead.
@harawata harawata changed the title Deprecate CGLIB Deprecate CGLIB proxy factory Mar 30, 2022
@coveralls
Copy link

coveralls commented Mar 30, 2022

Coverage Status

Coverage decreased (-0.007%) to 87.217% when pulling de54f20 on harawata:deprecate-cglib into a3576e6 on mybatis:master.

@harawata
Copy link
Member Author

@hazendaz @kazuki43zoo
Any concern?

@hazendaz
Copy link
Member

@harawata Sounds good. We may want to consider building support for byte buddy since following cglib notes to use that but given current code support this makes sense.

@hazendaz hazendaz self-requested a review March 31, 2022 20:12
@hazendaz
Copy link
Member

hazendaz commented Apr 1, 2022

@harawata Maybe it would be worthwhile to log a warning as well when the deprecated usage is in use.

@hazendaz hazendaz self-assigned this Apr 1, 2022
@hazendaz hazendaz merged commit 586dc88 into mybatis:master Apr 1, 2022
@hazendaz
Copy link
Member

hazendaz commented Apr 1, 2022

Thanks!

@harawata harawata deleted the deprecate-cglib branch April 1, 2022 20:15
@kazuki43zoo kazuki43zoo added the enhancement Improve a feature or add a new feature label May 15, 2022
@kazuki43zoo kazuki43zoo added this to the 3.5.10 milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants