Skip to content

Removing Bolt Versions 1 and 2 for 4.1 Driver #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Removing Bolt Versions 1 and 2 for 4.1 Driver #700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions driver/src/main/java/org/neo4j/driver/internal/async/connection/BoltProtocolUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
import io.netty.buffer.ByteBuf;

import org.neo4j.driver.internal.messaging.BoltProtocolVersion;
import org.neo4j.driver.internal.messaging.v1.BoltProtocolV1;
import org.neo4j.driver.internal.messaging.v2.BoltProtocolV2;
import org.neo4j.driver.internal.messaging.v3.BoltProtocolV3;
import org.neo4j.driver.internal.messaging.v4.BoltProtocolV4;
import org.neo4j.driver.internal.messaging.v41.BoltProtocolV41;
Expand All @@ -45,7 +43,7 @@ public final class BoltProtocolUtil
BoltProtocolV41.VERSION.toInt(),
BoltProtocolV4.VERSION.toInt(),
BoltProtocolV3.VERSION.toInt(),
BoltProtocolV2.VERSION.toInt() ) ).asReadOnly();
0 ) ).asReadOnly();

private static final String HANDSHAKE_STRING = createHandshakeString();

Expand Down
9 changes: 0 additions & 9 deletions driver/src/main/java/org/neo4j/driver/internal/handlers/PullHandlers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,11 @@
import org.neo4j.driver.internal.handlers.pulln.AutoPullResponseHandler;
import org.neo4j.driver.internal.handlers.pulln.BasicPullResponseHandler;
import org.neo4j.driver.internal.handlers.pulln.PullResponseHandler;
import org.neo4j.driver.internal.messaging.v1.BoltProtocolV1;
import org.neo4j.driver.internal.messaging.v3.BoltProtocolV3;
import org.neo4j.driver.internal.spi.Connection;

public class PullHandlers
{
public static PullAllResponseHandler newBoltV1PullAllHandler(Query query, RunResponseHandler runHandler,
Connection connection, UnmanagedTransaction tx )
{
PullResponseCompletionListener completionListener = createPullResponseCompletionListener( connection, BookmarkHolder.NO_OP, tx );

return new LegacyPullAllResponseHandler(query, runHandler, connection, BoltProtocolV1.METADATA_EXTRACTOR, completionListener );
}

public static PullAllResponseHandler newBoltV3PullAllHandler(Query query, RunResponseHandler runHandler, Connection connection,
BookmarkHolder bookmarkHolder, UnmanagedTransaction tx )
{
Expand Down
12 changes: 1 addition & 11 deletions driver/src/main/java/org/neo4j/driver/internal/messaging/BoltProtocol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
import org.neo4j.driver.internal.InternalBookmark;
import org.neo4j.driver.internal.async.UnmanagedTransaction;
import org.neo4j.driver.internal.cursor.ResultCursorFactory;
import org.neo4j.driver.internal.messaging.v1.BoltProtocolV1;
import org.neo4j.driver.internal.messaging.v2.BoltProtocolV2;
import org.neo4j.driver.internal.messaging.v3.BoltProtocolV3;
import org.neo4j.driver.internal.messaging.v4.BoltProtocolV4;
import org.neo4j.driver.internal.messaging.v41.BoltProtocolV41;
Expand Down Expand Up @@ -152,15 +150,7 @@ static BoltProtocol forChannel( Channel channel )
*/
static BoltProtocol forVersion( BoltProtocolVersion version )
{
if ( BoltProtocolV1.VERSION.equals( version ) )
{
return BoltProtocolV1.INSTANCE;
}
else if ( BoltProtocolV2.VERSION.equals( version ) )
{
return BoltProtocolV2.INSTANCE;
}
else if ( BoltProtocolV3.VERSION.equals( version ) )
if ( BoltProtocolV3.VERSION.equals( version ) )
{
return BoltProtocolV3.INSTANCE;
}
Expand Down
283 changes: 0 additions & 283 deletions driver/src/main/java/org/neo4j/driver/internal/messaging/v1/BoltProtocolV1.java
View file
Open in desktop

This file was deleted.

43 changes: 0 additions & 43 deletions driver/src/main/java/org/neo4j/driver/internal/messaging/v2/BoltProtocolV2.java
View file
Open in desktop

This file was deleted.

Loading