Removing Bolt Versions 1 and 2 for 4.1 Driver #700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjmwoods
force-pushed
the
4.1-deprecating-bolt-1-and-2
branch
from
1254103 to
1c354c7
Compare
There was a problem hiding this comment.
In general, looks good to me.
I wonder if we should take a day next week to consolidate message format and value (un)packers:
- Remove the v1 and v2
- Create unified (Un)Packer with the information from which bolt version types are available into the type itself.
- Create a factory for (Un)Packers that can be asked for an (Un)Packer supporting a bolt version. That factory would provide the unified unpacker with a enum set of the supported types
- Use that unified packers for a single message format. I'm sure the field keys and length of the message formats find a better home than the message format classes.
Only removing the protocol classes here feels incomplete.
gjmwoods
changed the title
|
Closing as superseded by #765 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 4.1 of the driver will no longer support Bolt V1 and V2 we remove unused code for those protocols.