Remove protocol 1 and 2 #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjmwoods
reviewed
Sep 30, 2020
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.*; |
There was a problem hiding this comment.
Could you double-check the neo4j checkstyles is being applied? Pretty sure its doesn't use *. (Personally not fussed either way just makes reviews easier)
There was a problem hiding this comment.
It is, interesting it is not being applied correctly.
There was a problem hiding this comment.
I've reseted the commit, and then applied the reformatting on all the modified files.
| */ | ||
| class MessageFormatV42Test | ||
| { | ||
| private static final MessageFormat format = BoltProtocolV4.INSTANCE.createMessageFormat(); |
There was a problem hiding this comment.
Yes, I will fix it.
The reference this protocols are not needed since it's not used by the driver anymore. During the remotion of these protocol version, the tests were refactoried to be specific per version instead of assume the re-use done on the protocols implementation.
bigmontz
force-pushed
the
remove-protocol-1-and-2
branch
from
525590f to
7f82e7b
Compare
gjmwoods
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference this protocols are not needed since it's not used by the driver anymore.
During the remotion of these protocol version, the tests were refactoried to be specific per version instead of
assume the re-use done on the protocols implementation.