added ipv6 support #122
Merged
added ipv6 support #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Proto string | ||
| HostIP string | ||
| IP string | ||
| IP6_LinkLocal string |
There was a problem hiding this comment.
Could you remove the underscores _? I try to keep the code consistent with: https://golang.org/doc/effective_go.html#mixed-caps
|
As you wished I removed the underscores from the name of the IPv6 fields |
|
Thanks @lukas2511! |
Closed
punkstar
added a commit
to punkstar/docker-gen
that referenced
this pull request
Dec 23, 2015
* Document the Network struct introduced by nginx-proxy#144 * Document the IPv6 support introduced by nginx-proxy#122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add IPv6 support to docker-gen.
IPv6 addresses of docker containers are available as
IP6_LinkLocalandIP6_Globalnext to the oldIPstring.I had to update the used docker client library to a newer version with support for
container.NetworkSettings.LinkLocalIPv6Addressandcontainer.NetworkSettings.GlobalIPv6Address