Add support for NetworkSettings.Networks #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Yes please 👍 |
|
This looks good to me as far as it goes. Any reason you didn't include |
|
@dustinblackman Looks good. Will hold off on merging in case the additional fields @md5 listed would be useful to include. I'm fine adding them now or holding off for another PR. Let me know whether you plan to update this PR or not. |
|
🤘 |
jwilder
added a commit
that referenced
this pull request
Dec 20, 2015
Add support for NetworkSettings.Networks
|
Thanks @dustinblackman @md5! |
punkstar
added a commit
to punkstar/docker-gen
that referenced
this pull request
Dec 23, 2015
* Document the Network struct introduced by nginx-proxy#144 * Document the IPv6 support introduced by nginx-proxy#122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Latest version of Docker and the go docker client adds
NetworkSettings.Networks, which contains information for Docker's multi-host networking. This adds support for applications such as your nginx-proxy to route to containers internally across Docker's networks without having to expose ports.I currently have this running in a production cluster and looks good!