Added flag -restart-container to allow restarting of docker containers.

[JustAdam]

Continued from #24 (code is moved from master branch)

...

The main purpose of this patch is too be able to run docker-gen by itself in a container. Therefore I think it is vital that this functionality is built into docker-gen and not provided by an external dependency (script/program). The external dependency provides an additional tool to maintain (ensuring the docker end point is available, ensure API calls are up to date etc.) and package.

I would really like to see this patch accepted, as it would make docker-gen much more usable (certainly for me and cnf!).

I agree with the syntax being funky, and have thought a bit more about the additional flag, and perhaps it is the only way to go. If we can agree, I will rewrite the patch to include a new flag: -restart-container=CONTAINER_ID.
So either the flag or old flag, both or none can be specified and all behaves as it did before. If both are specified then it issues the restart and the notify.

[jwilder]

Ok. You've convinced me. Crafting an API request via shell commands is kind of ugly.

Instead of -restart-containers, I think -notify-sighup might be a better name since it's not really restarting containers but sending a SIGHUP for notification. This would also allow some flexibility to add -notify-sigusr1 or other signals in the future.

Not needed for this patch but I'll probably add the ability to pass -notify-sighup multiple times instead of using CSV as well.

[JustAdam]

Here's the updated patch. Have coded it such that it will be trivial to pass in additional container IDs as well as signals.

[JustAdam]

Hmm, I am wondering whether to change config.NotifyContainers to a map[string]docker.Signal and then construct KillContainerOptions inside sendSignalToContainer(). Think that will make it easier to work with in future for additional signal type flags. But it will be a few days before I get to look at this again.

[JustAdam]

Patch updated.

[JustAdam]

Bump :-)

[jwilder]

Thanks! @JustAdam

[pwFoo]

Hello @jwilder I would need "-notify-sigusr1" to graceful reload a config. Any chance to get this feature for docker-gen?