Set correct permissions on <dest> file creation #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's used so that updating the file is atomic. I also had plans to add a check command option but have not implemented it. It would use the temp file as input and run a check config type commander such as |
JustAdam
force-pushed
the
generatefile-fix
branch
from
0ae3f26 to
061fbac
Compare
JustAdam
changed the title
|
I have updated the patch accordingly. |
|
Is either this or #27 likely to be merged? |
| if _, err := os.Stat(config.Dest); err == nil { | ||
| if fi, err := os.Stat(config.Dest); err == nil { | ||
| dest.Chmod(fi.Mode()) | ||
| dest.Chown(int(fi.Sys().(*syscall.Stat_t).Uid), int(fi.Sys().(*syscall.Stat_t).Gid)) |
There was a problem hiding this comment.
Both of these calls ignore the error return value.
|
Ah yes :) Fixed that |
JustAdam
force-pushed
the
generatefile-fix
branch
from
628260c to
694ed3c
Compare
|
Merged as 1b6ec. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of a new output file each time the config changes causes problems with its ownership and permissions; when the output file is on a Docker volume.
Without doing additional user adding/user space mapping stuff, Docker writes the file as root:root and 0600, which for all sense and purposes makes it unreadable for everything else.
If a file already exists, then the file's ownership and permissions are left untouched by Docker.
I couldn't see why a temp file was being used so this patch removes the use of it, and instead will truncate and overwrite the existing file.