gives enough time for argocd to verify job has finished #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ab-andresc! Welcome to the project! 🎉 Thanks for opening this pull request! Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. |
github-actions
bot
added
enhancement
ab-andresc
force-pushed
the
feat/update-ttl-seconds-on-job-to-work-with-argocd
branch
from
fc829f9 to
07fdc66
Compare
|
should solve |
sjberman
reviewed
Jun 10, 2025
ab-andresc
force-pushed
the
feat/update-ttl-seconds-on-job-to-work-with-argocd
branch
from
07fdc66 to
bbbae5b
Compare
github-actions
bot
added
the
documentation
ab-andresc
force-pushed
the
feat/update-ttl-seconds-on-job-to-work-with-argocd
branch
2 times, most recently
from
f01022d to
837a961
Compare
ab-andresc
force-pushed
the
feat/update-ttl-seconds-on-job-to-work-with-argocd
branch
from
083aebe to
1737039
Compare
sjberman
reviewed
Jun 11, 2025
github-actions
bot
removed
the
documentation
github-actions
bot
added
the
documentation
sjberman
reviewed
Jun 11, 2025
sjberman
reviewed
Jun 11, 2025
Co-authored-by: Saylor Berman <[email protected]>
sjberman
approved these changes
Jun 11, 2025
github-project-automation
bot
moved this from External Pull Requests
to ✅ Done
in NGINX Gateway Fabric
salonichf5
pushed a commit
that referenced
this pull request
Jun 11, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
salonichf5
pushed a commit
that referenced
this pull request
Jun 11, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
salonichf5
pushed a commit
that referenced
this pull request
Jun 11, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
salonichf5
added a commit
that referenced
this pull request
Jun 11, 2025
#3500) gives enough time for argocd to verify job has finished (#3487) Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify. Co-authored-by: ab-andresc <[email protected]>
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
Problem: Argocd can never find the job completion as TTL is set to 0 Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Argocd can never find the job completion as TTL is set to 0
Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
Testing: Manually tested on my cluster.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.