Skip to content

Expose ability to configure cert generator Job ttlSecondsAfterFinished. Set default to 30s. #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

salonichf5
Copy link
Contributor

Cherry pick commit for release 2.0.1

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Expose ability to configure cert generator Job ttlSecondsAfterFinished. Set default to 30s.

Problem: Argocd can never find the job completion as TTL is set to 0

Solution: Sets the default ttl seconds to 30 so that argocd has enough time to verify.
@salonichf5 salonichf5 requested a review from a team as a code owner June 11, 2025 19:42
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (92aa93b) to head (615b7d6).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.0    #3500      +/-   ##
===============================================
- Coverage        86.78%   86.74%   -0.04%     
===============================================
  Files              127      127              
  Lines            15079    15079              
  Branches            62       62              
===============================================
- Hits             13086    13080       -6     
- Misses            1841     1846       +5     
- Partials           152      153       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 merged commit 6febc8d into release-2.0 Jun 11, 2025
77 of 78 checks passed
@salonichf5 salonichf5 deleted the feat/argocd branch June 11, 2025 20:23
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 11, 2025
@sjberman sjberman removed the enhancement New feature or request label Jun 11, 2025
@sjberman sjberman changed the title Increase Timeout to Ensure ArgoCD Successfully Verifies Job Completion Expose ability to configure cert generator Job ttlSecondsAfterFinished. Set default to 30s. Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm-chart Relates to helm chart release-notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants