Feat: Add user-provided helm values for additional control plane service labels #3499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @michasHL! Welcome to the project! 🎉 Thanks for opening this pull request! |
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
github-actions
bot
added
documentation
|
I have hereby read the F5 CLA and agree to its terms |
…bels Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
sjberman
approved these changes
Jun 11, 2025
|
@michasHL Not sure exactly what's causing the pipeline failure, but try another run of |
bjee19
approved these changes
Jun 11, 2025
|
Ah yeah, one field in the README was not generated correctly. Running that make command will fix it. |
Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
Yeah I initially manually updated the file and missed that one. Thank you. |
salonichf5
pushed a commit
that referenced
this pull request
Jun 11, 2025
…ice labels (#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
salonichf5
added a commit
that referenced
this pull request
Jun 11, 2025
…ice labels #3499 (#3501) Feat: Add user-provided helm values for additional control plane service labels (#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly Co-authored-by: Michael Kranz <[email protected]>
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
…ice labels (nginx#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
…ice labels (nginx#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
nowjean
pushed a commit
to nowjean/nginx-gateway-fabric
that referenced
this pull request
Jun 14, 2025
…ice labels (nginx#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label.
Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart.
Testing: Local helm lint/install testing
Closes #3498
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.