feat: Add user-provided helm values for additional control plane service labels #3499 #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice labels (#3499) Problem: As a user that uses prometheus for everything metrics, I would like to target the control plane service with a specific label. Solution: Add the ability for users to provide additional service labels for the NGINX Gateway Fabric control plane service in the helm chart. Testing: Used helm lint/install --dry-run to make sure the k8s resources are created correctly
github-actions
bot
added
documentation
bjee19
approved these changes
Jun 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.0 #3501 +/- ##
===============================================
- Coverage 86.78% 86.74% -0.04%
===============================================
Files 127 127
Lines 15079 15079
Branches 62 62
===============================================
- Hits 13086 13080 -6
- Misses 1841 1847 +6
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjberman
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick for the commit into release 2.0.1