Use latest service swagger; Add deprecation warning for certificate deployment; Only output conf when debug flag is set #38
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetsarna
force-pushed
the
ps-dev-swagger-version
branch
3 times, most recently
from
7998f33 to
71e454e
Compare
kuthiala
approved these changes
Jun 11, 2025
We have had 2024-11-01-preview released for a while now and are consuming it in tools such as Terraform. We should also consume it in our Action so that customer get the latest API features.
The certificat object does not need a location parameter to create it. Added a deprecation message so we can retire it in a future release.
We don't want to output the user config in their actions run unnecessarily. When the user turns on the debug flag, the config can be printed otherwise it stays hidden from stdout.
The cmd itself has senstive info such as user configs so it makes sense to hide it under the debug flag like we are for the config itself.
puneetsarna
force-pushed
the
ps-dev-swagger-version
branch
from
71e454e to
b23ab51
Compare
amudukutore
approved these changes
Jun 11, 2025
ryepup
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.