Skip to content

Use latest service swagger; Add deprecation warning for certificate deployment; Only output conf when debug flag is set #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 11, 2025
Merged

Use latest service swagger; Add deprecation warning for certificate deployment; Only output conf when debug flag is set #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd19c92
Use latest service swagger
puneetsarna Jun 11, 2025
852a113
Add deprecation warning for certificate deployment
puneetsarna Jun 11, 2025
0d99a97
Only output conf when debug flag is set
puneetsarna Jun 11, 2025
b23ab51
Echo action cmd during debug
puneetsarna Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions github-action/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ inputs:
nginx-deployment-location:
description: "The location where the NGINX deployment is located. Example westcentralus"
required: false
deprecationMessage: "This field is not in use and will be removed in a future release. Consider dropping it from your Github Action configuration."
nginx-config-directory-path:
description: 'The NGINX configuration directory path relative to the root of the Git repository, example: "config/".'
required: false
Expand Down
2 changes: 1 addition & 1 deletion github-action/src/deploy-certificate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,8 @@ do
)
if [[ "$debug" == true ]]; then
az_cmd+=("--debug")
echo "${az_cmd[@]}"
fi
echo "${az_cmd[@]}"
set +e
"${az_cmd[@]}"
set -e
Expand Down
9 changes: 6 additions & 3 deletions github-action/src/deploy-config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,11 @@ echo "Listing the NGINX configuration file paths in the tarball."
tar -tf "$config_tarball"

encoded_config_tarball=$(base64 "$config_tarball")
echo "The base64 encoded NGINX configuration tarball"
echo "$encoded_config_tarball"

if [[ "$debug" == true ]]; then
echo "The base64 encoded NGINX configuration tarball"
echo "$encoded_config_tarball"
fi
echo ""

# Synchronize the NGINX configuration tarball to the NGINXaaS for Azure deployment.
Expand Down Expand Up @@ -174,7 +177,7 @@ az_cmd=(

if [[ "$debug" == true ]]; then
az_cmd+=("--debug")
echo "${az_cmd[@]}"
fi

echo "${az_cmd[@]}"
"${az_cmd[@]}"
2 changes: 1 addition & 1 deletion github-action/src/nginx-for-azure-certificate-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"resources": [
{
"type": "NGINX.NGINXPLUS/nginxDeployments/certificates",
"apiVersion": "2021-05-01-preview",
"apiVersion": "2024-11-01-preview",
"name": "[concat(parameters('nginxDeploymentName'), concat('/', parameters('name')))]",
"location": "[parameters('location')]",
"properties": {
Expand Down
2 changes: 1 addition & 1 deletion github-action/src/nginx-for-azure-configuration-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"resources": [
{
"type": "NGINX.NGINXPLUS/nginxDeployments/configurations",
"apiVersion": "2021-05-01-preview",
"apiVersion": "2024-11-01-preview",
"name": "[concat(parameters('nginxDeploymentName'), '/default')]",
"properties": {
"rootFile": "[parameters('rootFile')]",
Expand Down