Skip to content

Sidebar V3 Mobile Support #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Sidebar V3 Mobile Support #248

wants to merge 5 commits into from

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/466 and https://github.com/nginxinc/docs-platform/issues/490

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this May 8, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 8, 2025 22:19
@lamATnginx lamATnginx added the enhancement New feature or request label May 8, 2025
@lamATnginx
Copy link
Collaborator Author

Besides the attached alignment issue, this is ready for review:

Screenshot 2025-05-08 at 3 26 06 PM

This was referenced May 8, 2025
@nginx-jack
Copy link
Collaborator

This is looking great, and mobile sidebar is a new feature :D.
I'm not sure about the sticky breadcrumb for desktop though? Make sense for mobile, but it consumes limited vertical space on desktop. What do you think?

@lamATnginx
Copy link
Collaborator Author

This is looking great, and mobile sidebar is a new feature :D. I'm not sure about the sticky breadcrumb for desktop though? Make sense for mobile, but it consumes limited vertical space on desktop. What do you think?

Thanks for reviewing! Ahh I see what you mean, I agree on desktop, it is overkill and honestly half-baked where the content goes into a weird void - missing some shadow to indicate more content above. Though I can see some arguments about consistency. I will remove the sticky for all scopes (e.g. mobile, ipad, desktop) for now and in future PR, if enough complaints, we can add it back in for all scopes.

@lamATnginx lamATnginx force-pushed the mobile-sidebar branch 3 times, most recently from bbf3624 to c25ae9b Compare May 14, 2025 17:05
@lamATnginx
Copy link
Collaborator Author

This PR and branch is completely broken due to merged commits not being signed. Dup of #252

@lamATnginx lamATnginx closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants