Skip to content

Sidebar Mobile Support #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Sidebar Mobile Support #252

merged 1 commit into from
May 19, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/466 and https://github.com/nginxinc/docs-platform/issues/490

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this May 14, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner May 14, 2025 17:21
@lamATnginx lamATnginx added the enhancement New feature or request label May 14, 2025
@lamATnginx lamATnginx mentioned this pull request May 14, 2025
Closed
4 tasks
nginx-jack
nginx-jack reviewed May 15, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

❌ Playwright visual snapshot differences were detected.

View the Playwright report
To approve the snapshot changes and update the snapshots, please comment: /approve-snapshots

@lamATnginx
Copy link
Collaborator Author

Changes with removing inline display: none; broke the old theme. Additional changes were made to fix issue + clean up code.

@nginx-jack nginx-jack self-requested a review May 19, 2025 13:00
nginx-jack
nginx-jack approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@nginx-jack nginx-jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Update with main, and you should be good to go.

@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/252/

@lamATnginx lamATnginx merged commit 9c28d1c into main May 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack approved these changes

Assignees

@lamATnginx lamATnginx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamATnginx @nginx-jack