Skip to content

Bad wording and example fixes in cache documentation. #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2017
Merged

Bad wording and example fixes in cache documentation. #1424

merged 1 commit into from
Nov 5, 2017

Conversation

fredericDelaporte
Copy link
Member

No description provided.

@fredericDelaporte fredericDelaporte added this to the 5.0.1 milestone Nov 4, 2017
@fredericDelaporte fredericDelaporte mentioned this pull request Nov 4, 2017
Merged
gliljas
gliljas reviewed Nov 4, 2017
View reviewed changes
doc/reference/modules/nhibernate_caches.xml Outdated
@@ -209,7 +209,7 @@
<section id="NHibernate.Caches.SysCache">
<title>SysCache Configuration</title>
<para>
As SysCache relies on <classname>System.Web.Caching.Cache</classname> for the underlying implementation.
SysCache relies on <classname>System.Web.Caching.Cache</classname> for the underlying implementation.
Following NHibernate configuration settings are available:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following

gliljas
gliljas reviewed Nov 4, 2017
View reviewed changes
doc/reference/modules/nhibernate_caches.xml Outdated
<para>
As runtime memory relies on <classname>System.Runtime.Caching.MemoryCache</classname> for the
RtMemoryCache relies on <classname>System.Runtime.Caching.MemoryCache</classname> for the
underlying implementation.
Following NHibernate configuration settings are available:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following

Copy link
Member Author

@fredericDelaporte fredericDelaporte Nov 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I frequently read articles where I find similar article omissions. Maybe I am missing the rule allowing their omission, or maybe that is an american thing (I am reading mainly an american paper, IEEE Spectrum). I would be glad if you can tell me more about that.

(It is not a thing from my native language, in French articles can not be omitted that way.)

@fredericDelaporte
Copy link
Member Author

Changed.

@gliljas gliljas merged commit 8da7a19 into nhibernate:master Nov 5, 2017
@fredericDelaporte fredericDelaporte deleted the cache-doc branch November 5, 2017 19:16
@fredericDelaporte
Copy link
Member Author

Thanks Gunnar,
For a PR with a single commit, doing a "Rebase and merge" is less noisy than a "Create a merge commit". It avoids the merge commit which has not much interests when the PR was only having one commit.

@gliljas
Copy link
Member

gliljas commented Nov 5, 2017

Ah, sorry, I didn't know that was an option. Rebasing is definitely a better option. Will keep it in mind, thanks!

@fredericDelaporte
Copy link
Member Author

I am just following Alexander's recommendations he told me on a previous PR: #582 (comment)

@gliljas
Copy link
Member

gliljas commented Nov 5, 2017

Sounds reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gliljas gliljas gliljas approved these changes

Assignees
No one assigned
Labels
p: Lowest r: Fixed t: Bug
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericDelaporte @gliljas