NH-3931 - Invalid order of child inserts #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericDelaporte
referenced
this pull request
in hibernate/hibernate-orm
Mar 26, 2017
fredericDelaporte
force-pushed
the
NH-3931-2
branch
2 times, most recently
from
9937f7b to
f7adbc4
Compare
| var propertyValues = action.State; | ||
| var propertyTypes = action.Persister.ClassMetadata.PropertyTypes; | ||
| var propertyTypes = action.Persister.EntityMetamodel?.PropertyTypes; |
There was a problem hiding this comment.
ClassMetadata current NHibernate implementation is reaching the underlying EntityMetamodel.PropertyTypes. As ClassMetadata seems "more optional" than EntityMetamodel, better use EntityMetamodel directly. (CustomPersister on NHibernate side does not provide any of them, but on Hibernate side, it does provide EntityMetamodel while still not providing ClassMetadata.)
fredericDelaporte
force-pushed
the
NH-3931-2
branch
2 times, most recently
from
200daa3 to
2d3d185
Compare
fredericDelaporte
force-pushed
the
NH-3931-2
branch
from
2d3d185 to
c2afa14
Compare
fredericDelaporte
force-pushed
the
NH-3931-2
branch
from
c2afa14 to
155f2f9
Compare
|
@fredericDelaporte next time, if you want to preserve multiple commits on a PR, please make a merge commit. So:
|
|
Ok, understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test cases and fix for NH-3931.
Test cases ported from HHH-9864, HHH-11216 and HHH-11585, relaxed in terms of batching expectations, and completed with some missing cases.
Fix not ported but elaborated from current NHibernate implementation.
This PR will hopefully replace the previous one, which was attempting a new sorting algorithm. This new algorithm was better at batching some cases, but was failing on many previously supported cases. And it was having an O(n^3) complexity over batched entities classes count, where current algorithm, even fixed, has an O(n) complexity over batched entities count.