Skip to content

ApplyXFM does not set default value of required flag #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
satra opened this issue Sep 17, 2012 · 1 comment
Closed

ApplyXFM does not set default value of required flag #459

satra opened this issue Sep 17, 2012 · 1 comment
Labels

Comments

@satra
Copy link
Member

satra commented Sep 17, 2012

from @DavidGutman

Just noticed this, after scratching my head for a bit.... by default
it seems the ApplyXfm doesn't bass the applyxfm.inputs.apply_xfm=True
parameter... in which case it is rerunning the registration ...

I couldn't figure out why my transformation was working oddly and
realized it's because that flag wasn't being passed, and I
inadvertently assumed that that was the default behavior of ApplyXfm
(i.e. to apply an XFM)....

Not sure if this should be changed or not as the default behavior that
can be overridden (in which case.. you'd probably just want to use
fsl.FLIRT() anyway)..

More of a semantics thing I guess..

ApplyXfm
Code: http://github.com/nipy/nipype/blob/master/nipype/interfaces/fsl/preprocess.py#L495

Wraps command flirt

Currently just a light wrapper around FLIRT, with no modifications

ApplyXfm is used to apply an existing tranform to an image

Examples

import nipype.interfaces.fsl as fsl
from nipype.testing import example_data
applyxfm = fsl.ApplyXfm()
applyxfm.inputs.in_file = example_data('structural.nii')
applyxfm.inputs.in_matrix_file = example_data('trans.mat')
applyxfm.inputs.out_file = 'newfile.nii'
applyxfm.inputs.reference = example_data('mni.nii')
applyxfm.inputs.apply_xfm = True
result = applyxfm.run()
Inputs:

[Mandatory]
in_file: (an existing file name)
input file
reference: (an existing file name)
reference file

[Optional]
angle_rep: ('quaternion' or 'euler')
representation of rotation angles
apply_xfm: (a boolean)
apply transformation supplied by in_matrix_file

David A Gutman, M.D. Ph.D.

@Gilles86
Copy link
Contributor

Hey,

I just started building my own preproc-pipeline and just found out about this and wanted to post this issue. It took me a lot of time and frustration to figure out today. I do love the software so keep up the good work.

:)

satra added a commit that referenced this issue Dec 17, 2012
satra added a commit to satra/nipype that referenced this issue Dec 18, 2012
* master: (24 commits)
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  doc: added version config info to doc
  enh: added output versioning as well
  BF: Wrap imports of optional deps in try-except block
  STY: Cleanup some long lines.
  ENH: Making interface module name dcmstack to match package
  ENH: Allow control of meta data filtering in DcmStack.
  BF: Fixed bug in CopyMeta
  ENH: Default to 'force=True' when reading DICOM files.
  BF: CopyMeta inputspec and outputspec were undefined.
  WIP: Initial interface to dcmstack package.
  sty: pep8
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (319 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (188 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (319 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (264 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (76 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (266 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (188 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Dec 21, 2012
* master: (76 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Mar 27, 2013
* master: (188 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Mar 27, 2013
* master: (80 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Mar 27, 2013
* master: (214 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
bpinsard pushed a commit to bpinsard/nipype that referenced this issue Apr 17, 2013
* master: (188 commits)
  fixed paths
  Back to dev
  0.7 release
  Code cleanup.
  doc: updated inputs help to indicate FSL and AFNI inaccuracy when using bounds_by_brainmask
  Fix nipy#493
  Fixes nipy#459
  fixed doctests
  changelog
  fix: ants workflows setup
  BF: Fixed several issues with GroupAndStack interface
  DOC: Various clean up an improvements to docstrings.
  DOC: Added example to LookupMeta docstring
  ENH: Allow meta_keys input to LookupMeta be a mapping.
  minor fixes
  deprecated version should be a string, added AFNITraitedSpec for backward compatibility
  docs
  PEP8
  name_source can be a list, make "infolder" a deprecated name
  Removed unnecessary outputsspecs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants